Commit Briefs

9f799d9055 rsadowski

Standardize logging with bgpd (main)

Tweak and OK claudio@


4a9fc8a790 rsadowski

remove empty server_http_init

OK claudio


694ec08805 claudio

Error out on presence of Content-Length and Transfer-Encoding headers

for GET, HEAD and other methods that should have no body. Ignoring the Content-Length header makes httpd vulnerable to HTTP request smuggling. A crafted GET request may embed an extra HTTP request which could bypass a proxy or WAF but then is handled by httpd. Remove the special case for TRACE and CONNECT in the Content-Length handling. Move those checks into the method switch at the end of the header parsing phase and by that also cover more methods including GET and HEAD. If either header is present simply abort the connection, nobody should send extra data along GET and HEAD requests. Add an an explicit HTTP_METHOD_TRACE case above the default case to indicated that we deliberately don't handle TRACE requests. This security vulnerability was found by Nicola Staller of SySS GmbH. With and OK rsadowski@ previous version also OK florian@


5e36945a5e claudio

In server_read_httpchunks() do not blindly enable the bufferevent.

This leads to a use-after-free since the bev->readcb() call could free the memory holding the bev right before the bufferevent_enable() call. Reported by Pontus Stenetorp. OK florian@ rsadowski@


6fb75f225b schwarze

Slightly iprove a confusing wording in the parse.y manuals:

The things that need quoting are not necessarily "argument names", and not even necessarily "names" at all, so just talk about "arguments". "I guess?" florian@ and no objection from otto@, both back in July 2025. Actually, the quoting rules are more complicated than the text makes believe, but i do not know how to better describe them. It may not be easy because some suspect the implementation may be somewhat adhoc rather than based on cleary defined lexical rules.


a030517f06 rsadowski

validate return_uri_len before copying data

Spotted by tb@, ok claudio


38978fc61e rsadowski

fix scan-build dead stores findings

- httpd.c:533 – q assigned but immediately overwritten in the loop - server.c:891 – inrd/inwr assigned, then reassigned, never actually needed - server_fcgi.c:678,690 – kv result unused OK stsp@


6e77fedee8 tb

httpd: fix server_http_time() to emit GMT times again

The HTTP standard RFC 9110 requires GMT, in HTTP-date. We used to do this until a recent change to localtime.c changed GMT to UTC. From Sören Tempel, ok sthen


3f1c295fee rsadowski

Add "no banner" option to suppress Server header

Introduces a global and per-server "[no] banner" directive that prevents httpd from sending the Server HTTP response header and removes server identification from error documents. The SERVER_SOFTWARE CGI environment variable remains set as required by RFC 3875. Diff by Lloyd (thanks), ok kirill@


4525f6dfc1 rsadowski

Add missing GZIP_STATIC flag to SRVFLAG_BITS macro

GZIP_STATIC flag at position \33 was missing from the debug string. Also correct the truncated PATH_REWRITE/NO_PATH_REWRITE flag names. The PATH_REWRITE and NO_PATH_REWRITE flag names were truncated to PATH and NO_PATH in the SRVFLAG_BITS string definition. OK kirill@ deraadt@


Branches

Tags

This repository contains no tags

Tree