commit bd31b5ba996cf10c5ce0cca01797a9214066ceb6
from: claudio <claudio@openbsd.org>
date: Thu Nov 21 13:06:19 2024 UTC

imsg_flush no longer returns EAGAIN. Simplify proc_flush_imsg() accordingly.

Issue spotted by op@

commit - a6cad40b9e072c4880d925603e8a227ccb98f2aa
commit + bd31b5ba996cf10c5ce0cca01797a9214066ceb6
blob - 1da7e585fc4dedce97888c27ebcefc27efdda24a
blob + 233ea86b191fd86c5a373248d1541cb99b8f3c05
--- proc.c
+++ proc.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: proc.c,v 1.45 2024/01/17 10:01:24 claudio Exp $	*/
+/*	$OpenBSD: proc.c,v 1.46 2024/11/21 13:06:27 claudio Exp $	*/
 
 /*
  * Copyright (c) 2010 - 2016 Reyk Floeter <reyk@openbsd.org>
@@ -818,10 +818,7 @@ proc_flush_imsg(struct privsep *ps, enum privsep_proci
 	for (; n < m; n++) {
 		if ((ibuf = proc_ibuf(ps, id, n)) == NULL)
 			return (-1);
-		do {
-			ret = imsg_flush(ibuf);
-		} while (ret == -1 && errno == EAGAIN);
-		if (ret == -1)
+		if ((ret = imsg_flush(ibuf)) == -1)
 			break;
 		imsg_event_add(&ps->ps_ievs[id][n]);
 	}