Commit Diff

Commit:
050dfc424dd88dad7ef6b0a4e046c0cf08cab81a
From:
florian <florian@openbsd.org>
Date:
Message:
plug fd leak introduced in "avoid toctu" rewrite. Issue reported by job OK tb, job
Actions:
Patch | Tree
commit - 45de6218739768fe46a0ff4773e4f34bce1984d0
commit + 050dfc424dd88dad7ef6b0a4e046c0cf08cab81a
blob - 851ad462b026ae91db7fc785ae26ed0de1a703fc
blob + cdcc11cd800eb4a5b4c896f4912752a5ee87387e
--- server_file.c
+++ server_file.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: server_file.c,v 1.79 2024/04/16 17:15:50 florian Exp $	*/
+/*	$OpenBSD: server_file.c,v 1.80 2024/04/29 16:17:46 florian Exp $	*/
 
 /*
  * Copyright (c) 2006 - 2017 Reyk Floeter <reyk@openbsd.org>
@@ -287,6 +287,7 @@ server_file_request(struct httpd *env, struct client *
 		if ((ret = server_response_http(clt, ret, media, -1,
 		    MINIMUM(time(NULL), st->st_mtim.tv_sec))) == -1)
 			goto fail;
+		close(fd);
 		goto done;
 	}