commit 7ef192f50c90fdf6076af21336101fafcccfe678
from: tb <tb@openbsd.org>
date: Thu Apr  2 13:28:22 2026 UTC

relayd: fix NULL check for strdup()

Due to a copy-paste error, relay_lookup_query() would check the wrong kv
member for NULL.

From Jan Schreiber

commit - 192c004f0b9ce8bc0c0ad277ea43052717f12cf9
commit + 7ef192f50c90fdf6076af21336101fafcccfe678
blob - 056cd076171fb4cdbbc59b042cc45e3b919fb37c
blob + bd71353980ece9207e186ba5e1444a760aa80986
--- relay_http.c
+++ relay_http.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: relay_http.c,v 1.94 2026/03/08 11:06:30 rsadowski Exp $	*/
+/*	$OpenBSD: relay_http.c,v 1.95 2026/04/02 13:28:22 tb Exp $	*/
 
 /*
  * Copyright (c) 2006 - 2016 Reyk Floeter <reyk@openbsd.org>
@@ -1030,7 +1030,7 @@ relay_lookup_query(struct ctl_relay_event *cre, struct
 	if (match->kv_key == NULL)
 		goto done;
 	match->kv_value = strdup(tmpval);
-	if (match->kv_key == NULL)
+	if (match->kv_value == NULL)
 		goto done;
 	ret = 0;